Conditionally add fiber-storage dependency for Ruby < 3.2 #5456
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey, thanks for taking a look at this. This build runs Ruby 3.2.0 but it's currently failing because of a https://github.com/rmosolgo/graphql-ruby/actions/runs/19062331874/job/54444654887?pr=5456 |
OuYangJinTing
force-pushed
the
chore/fiber-storage-dependency
branch
from
9b2a65e to
a465073
Compare
OuYangJinTing
force-pushed
the
chore/fiber-storage-dependency
branch
from
a465073 to
8cd47d4
Compare
Contributor
Author
|
@rmosolgo Sorry. I didn't notice the test issue before, but I've already fixed it. |
Owner
|
Thanks for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fiber-storagedependency only was introduced in Ruby versions prior to 3.2.